From 02ce0f4d8cb5616440938d62b548e47d413847a2 Mon Sep 17 00:00:00 2001 From: Abraham Murciano Date: Thu, 15 Apr 2021 20:13:16 +0300 Subject: [PATCH 1/3] Made disabled login button have clearer text Having a disabled login button with almost transparent text makes it hard to read, thus not as aesthetic as a clearer label. IMHO transparent text is not that good an indicator that the button is unclickable. Besides, everyone knows that they have to enter a password before they log in, as is evident by the password input, and by the fact that they created a password. --- kde/sddm/Login.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kde/sddm/Login.qml b/kde/sddm/Login.qml index d35499f..0d37ed3 100644 --- a/kde/sddm/Login.qml +++ b/kde/sddm/Login.qml @@ -111,7 +111,7 @@ SessionManagementScreen { contentItem: Text { text: loginButton.text font: loginButton.font - opacity: enabled ? 1.0 : 0.3 + opacity: enabled ? 1.0 : 0.8 color: "#ffffff" horizontalAlignment: Text.AlignHCenter verticalAlignment: Text.AlignVCenter From f2b1f3a833fa3fbf39b88d68308b28773c5fff5c Mon Sep 17 00:00:00 2001 From: Abraham Murciano Date: Thu, 15 Apr 2021 21:42:30 +0300 Subject: [PATCH 2/3] Made login button fill parent width The login button now fills the parent width, since when the ActionButtons are too large and overflow the fixed 270, it causes the inputs to be as wide as them but not the button, so this change should make the button match the inputs in such cases. --- kde/sddm/Login.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kde/sddm/Login.qml b/kde/sddm/Login.qml index 0d37ed3..8bd5dda 100644 --- a/kde/sddm/Login.qml +++ b/kde/sddm/Login.qml @@ -120,8 +120,8 @@ SessionManagementScreen { background: Rectangle { id: buttonBackground - width:30 - height: 270 + height: parent.width + width: height / 9 radius: width / 2 rotation: -90 anchors.centerIn: parent From c17dff593d835e95a6f28733af1894a547084f48 Mon Sep 17 00:00:00 2001 From: Abraham Murciano Date: Thu, 15 Apr 2021 21:44:52 +0300 Subject: [PATCH 3/3] Use parent width rather than fixed width When the action buttons are too wide, it causes the text box to be that wide, since the `Input` has `Layout.fillWidth: true` set, causing the text to overflow the background. This change makes the background expand with the text. --- kde/sddm/components/Input.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kde/sddm/components/Input.qml b/kde/sddm/components/Input.qml index a667f43..a1295ec 100644 --- a/kde/sddm/components/Input.qml +++ b/kde/sddm/components/Input.qml @@ -12,10 +12,10 @@ TextField { color: "#1E2326" opacity: 0.7 radius: parent.width / 2 - height: 30 - width: 270 + width: parent.width + height: width / 9 border.width: 1 border.color: "#121517" anchors.centerIn: parent } -} \ No newline at end of file +}